Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean tests #75

Merged
merged 6 commits into from
Feb 26, 2019
Merged

Clean tests #75

merged 6 commits into from
Feb 26, 2019

Conversation

gdiazlo
Copy link
Contributor

@gdiazlo gdiazlo commented Feb 26, 2019

Fix tests and shutdown/close code

@gdiazlo gdiazlo requested review from jllucas and aalda February 26, 2019 12:32
jllucas
jllucas approved these changes Feb 26, 2019
View reviewed changes
Copy link

@jllucas jllucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aalda
aalda approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@aalda aalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalda aalda merged commit f07dbd1 into BBVA:master Feb 26, 2019
suizman pushed a commit to jllucas/qed that referenced this pull request Jun 4, 2019
@aalda
Merge pull request BBVA#75 from gdiazlo/clean_tests
67506db 
Clean tests

Former-commit-id: f07dbd1
suizman pushed a commit that referenced this pull request Sep 30, 2019
@aalda
Merge pull request #75 from gdiazlo/clean_tests
eb147ca 
Clean tests

Former-commit-id: 6b04549 [formerly f07dbd1]
Former-commit-id: 67506db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalda aalda aalda approved these changes

@jllucas jllucas jllucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdiazlo @jllucas @aalda